Support multiple sets of data requirements #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lee1043 Can you please take a look at the updated data requirements for your annual cycle metric and the associated test to confirm that is what you intended |
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
* fix-cache: docs: changelog chore: retry downloads if they fail
Contributor
Author
|
This is a very light touch fix to #240. This should be sufficient until we have stricter requirements |
lee1043
approved these changes
Apr 30, 2025
Contributor
lee1043
left a comment
lee1043
left a comment
There was a problem hiding this comment.
Confirmed the annual cycle works okay with ts variable. Couldn't complete because of CMEC test failing, but as it will be addressed in a separate PR, I think this PR is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support multiple data requirements, either a list of data requirements or a list of lists of data requirements where each inner list is processed independently.
These different sets of data requirements can have different group bys and different filters.
Checklist
Please confirm that this pull request has done the following:
changelog/