validate hpc slurm config using pydantic #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
lewisjared
approved these changes
Sep 4, 2025
Contributor
lewisjared
left a comment
lewisjared
left a comment
There was a problem hiding this comment.
Some minor changes, but nice stuff. Should we do something similar for PBS?
Comment on lines
+45
to
+61
| username: str | ||
| partition: str | None = None | ||
| log_dir: str = "runinfo" | ||
| qos: str | None = None | ||
| req_nodes: Annotated[int, Field(strict=True, ge=1, le=1000)] = 1 | ||
| cores_per_worker: Annotated[int, Field(strict=True, ge=1, le=1000)] = 1 | ||
| mem_per_worker: Annotated[float, Field(strict=True, gt=0, lt=1000.0)] | None = None | ||
| max_workers_per_node: Annotated[int, Field(strict=True, ge=1, le=1000)] = 16 | ||
| validation: StrictBool = False | ||
| walltime: str = "00:30:00" | ||
| scheduler_options: str = "" | ||
| retries: Annotated[int, Field(strict=True, ge=1, le=3)] = 2 | ||
| max_blocks: Annotated[int, Field(strict=True, ge=1)] = 1 # one block mean one job? | ||
| worker_init: str = "" | ||
| overrides: str = "" | ||
| cmd_timeout: Annotated[int, Field(strict=True, ge=0)] = 120 | ||
| cpu_affinity: str = "none" |
Contributor
There was a problem hiding this comment.
Should we have documentation for these fields?
Contributor
Author
There was a problem hiding this comment.
Most of them are from parsl directly. We could document the fields from us and refer others to the parsl documents? What do you think of it?
Contributor
There was a problem hiding this comment.
Ahh ok. Maybe add a link to the parsl docs to make it easier to find this linkage
lewisjared
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please confirm that this pull request has done the following:
changelog/