refactor: Move executor definition to the ref package #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
* origin/main: chore: Fix coverage chore: Changelog test: Fix integration test chore: Update stubs for pooch chore: Update tests again chore: Update documentation chore: Update test-data docs: Update sample data commands chore: Fetch sample data automatically Run all tests Add changelog entry Use GitHub term "pull request" instead of "merge request" Add a few more updates test: Update tests chore: remove esgpull from CI chore: remove esgpull chore: Don't use esgf data anymore feat: Fetch data from https://github.com/CMIP-REF/ref-sample-data Update developer docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the definition of the LocalExecutor and manager from
ref_core.executortoref.executor.The declaration of the protocol describing an executor was kept in the core.
The
LocalExectorhas a dependence on theConfigfrom therefpackage.Checklist
Please confirm that this pull request has done the following:
changelog/