fix(tests): use local ignore list in solve regression tests#606
Merged
lewisjared merged 2 commits intomainfrom Mar 30, 2026
Merged
fix(tests): use local ignore list in solve regression tests#606lewisjared merged 2 commits intomainfrom
lewisjared merged 2 commits intomainfrom
Conversation
The solve regression tests were using Config.default() which downloads the ignore list from the main branch on GitHub. This caused tests to fail when the local default_ignore_datasets.yaml was updated but the remote version hadn't been refreshed yet. Add a solve_config fixture that points to the repo's local default_ignore_datasets.yaml and use it in all three provider regression test files.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lewisjared
added a commit
that referenced
this pull request
Mar 30, 2026
…f into pmp-mov-issue-583 * 'pmp-mov-issue-583' of github.com:Climate-REF/climate-ref: chore: add changelog for #606 fix(tests): use local ignore list in solve regression tests Add docs on configuring Dask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The solve regression tests were using
Config.default()which downloadsdefault_ignore_datasets.yamlfrom themainbranch on GitHub. This caused tests to fail when the local ignore list was updated (e.g. adding new entries to sea-ice-sensitivity) but the cached remote version hadn't refreshed yet.This adds a
solve_configsession-scoped fixture toconftest_plugin.pythat points to the repo's localdefault_ignore_datasets.yaml, and updates all three provider regression test files (esmvaltool, pmp, ilamb) to use it.The production download-from-GitHub behavior is unchanged -- only tests now use the local file.
Checklist
Please confirm that this pull request has done the following:
changelog/