test(core): add series.json regression comparison#706
Merged
Conversation
Diagnostic series outputs were never compared against the committed regression data: build_execution_result regenerates series.json and validation only checked CMEC bundle structure, so an empty/stale series.json passed silently (issue #703). Add validate_series_regression to assert regenerated series match the committed expected series, wired into both RegressionValidator.validate and the deprecated DiagnosticValidator.validate. Sanitise the regenerated series via ExecutionRegression.output_replacements so committed <OUTPUT_DIR>/<TEST_DATA_DIR> placeholders compare equal to expanded paths. Add unit tests for the guard and a TODO for the equivalent CMEC bundle content check.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #703.
Diagnostic series outputs (
series.json) were never compared against the committed regression data.build_execution_resultre-extracts and overwritesseries.jsonon every run, and validation only checked CMEC bundle structure an empty or staleseries.jsonpassed silently. A diagnostic could change which series it emits (or have wrong/empty committed data) without any regression test failing.Checklist
Please confirm that this pull request has done the following:
changelog/