-
Notifications
You must be signed in to change notification settings - Fork 10
Add ILAMB standard analysis #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI: You can use a branch as a dependency https://docs.astral.sh/uv/concepts/projects/dependencies/#git |
|
This now implements the full metric. I have downloaded some local (historical/land-hist) data to illustrate the grouping works correctly. I get the following when I run /home/nate/.config/cmip_ref/tmp/ilamb/
└── ilamb_standard_tas_cru4.02
├── 6cdca8780b5d843db6900e05fecdea14b4e82358
│ ├── CanESM5-r1i1p1f1-gn.csv
│ ├── CanESM5-r1i1p1f1-gn.nc
│ ├── CanESM5-r1i1p1f1-gn_None_bias.png
│ ├── CanESM5-r1i1p1f1-gn_None_biasscore.png
│ ├── CanESM5-r1i1p1f1-gn_None_mean.png
│ ├── CESM2-r1i1p1f1-gn.csv
│ ├── CESM2-r1i1p1f1-gn.nc
│ ├── CESM2-r1i1p1f1-gn_None_bias.png
│ ├── CESM2-r1i1p1f1-gn_None_biasscore.png
│ ├── CESM2-r1i1p1f1-gn_None_mean.png
│ ├── output.json
│ ├── Reference.nc
│ └── Reference_None_mean.png
└── a83768dcad7f86356ade937483bc9d409aa116bc
├── CESM2-r1i1p1f1-gn.csv
├── CESM2-r1i1p1f1-gn.nc
├── CESM2-r1i1p1f1-gn_None_bias.png
├── CESM2-r1i1p1f1-gn_None_biasscore.png
├── CESM2-r1i1p1f1-gn_None_mean.png
├── output.json
├── Reference.nc
└── Reference_None_mean.pngwhich is the behavior I expected. I have many things still to polish but before the PR is ready I need to:
I just wanted you @lewisjared to see how I was going about the integration of the metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Description
Adds the ILAMBStandard Metric to the ILAMB provider that runs our standard analysis. A few comments:
Checklist
Please confirm that this pull request has done the following:
changelog/