fix: mark execution failed when result ingestion fails#740
Merged
Conversation
When a diagnostic ran successfully but persisting its result bundle failed (malformed CMEC JSON, controlled-vocabulary/schema mismatch, or any DB insert error), the ingestion exception was swallowed and the execution was still marked successful and the execution group cleaned. The savepoint had already rolled back the metric/series/output inserts, so the execution was recorded as successful with zero metric values, and because the group was clean the next solve never retried it — silent data loss. The ingestion except block now marks the execution failed and returns, leaving the group dirty so the next solve retries it, mirroring the existing system-failure branch in the same function.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a diagnostic ran successfully but persisting its result bundle failed (malformed CMEC JSON, controlled-vocabulary/schema mismatch, or any DB insert error),
handle_execution_resultswallowed the exception and then still marked the execution successful and the execution group clean. Because the ingestion runs inside a savepoint that rolls back the metric/series/output inserts, the execution was recorded as successful with zero metric values, and since the group was marked clean the nextref solvenever retried it — silent data loss on the framework's core job of producing metric values.The ingestion
exceptblock now marks the execution failed and returns, leaving the group dirty so the next solve retries it. This mirrors the existing system-failure branch in the same function. A new regression test drives a successful diagnostic whose ingestion raises and asserts the execution ends up failed with the group still dirty.Checklist
Please confirm that this pull request has done the following:
changelog/