Skip to content

Conversation

@minxu74
Copy link
Contributor

@minxu74 minxu74 commented Feb 3, 2025

Implement CMEC output and metric bundle standards using pydantic

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/
  • Inline documents

Partially address the issue #70

Copy link
Contributor

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are an initial set of suggestions

@lewisjared
Copy link
Contributor

Ahh I see that you ran ruff over the code which resolved a bunch of the formatting suggestions

"name": "National Biomass and Carbon data set for the Year 2000",
},
},
"log": "cmec_output.log",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nocollier As mentioned on slack the CMEC output bundle has a log field which takes a log file

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@minxu74
Copy link
Contributor Author

minxu74 commented Feb 4, 2025

@lewisjared I plan to add the changelog, so which one shall I use, "feature" or "improvement"? Thanks

@lewisjared
Copy link
Contributor

@lewisjared I plan to add the changelog, so which one shall I use, "feature" or "improvement"? Thanks

This is a new feature

@lewisjared
Copy link
Contributor

Nice stuff @minxu74. I think all that remains is adding a dependency on pydantic to the ref_core package.

uv add --package cmip_ref_core pydantic

@lewisjared
Copy link
Contributor

Would you like to get this merged as is, and then do any follow up later. It is pretty self contained at the moment, but you would have to merge main back into this branch if you wanted to work on any other parts of the codebase as they have likely changed since you made this branch

@minxu74
Copy link
Contributor Author

minxu74 commented Feb 7, 2025

@lewisjared I plan to submit another two commits tonight to address your suggestions and add more comments on the arguments of class methods. After that, if you and @acordonez agree, I can merge it to the main first as it does not interact with other ref components yet. We could create another PR to integrate the CMEC validators on other ref components. I wonder if it works?

@lewisjared
Copy link
Contributor

I think that is a good idea. We are still actively building so I don't mind if this isn't 100% yet as it's more important to see how it works with the metrics providers

@minxu74 minxu74 changed the title [WIP] Initially implement CMEC under cmip_ref_core Initially implement CMEC under cmip_ref_core Feb 8, 2025
@minxu74 minxu74 merged commit ca384fe into main Feb 8, 2025
13 checks passed
@minxu74 minxu74 deleted the Implementation_Of_CMEC branch February 8, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants