Test whether provided error bound is satisfied#20
Merged
Merged
Conversation
treigerm
commented
Apr 10, 2025
juntyr
requested changes
Apr 10, 2025
Collaborator
juntyr
left a comment
juntyr
left a comment
There was a problem hiding this comment.
This looks great! There are just some minor fixes needed to the error bound check (I now have too much experience with its edge cases)
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
juntyr
approved these changes
Apr 11, 2025
Member
Author
|
Thanks for the review! I don't want to know how you learnt about all of these edge cases 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adding a new test which verifies that the pointwise error is not exceeded. A while back I discussed with @milankl and this could be the only test, we actually need. In the end, all the other tests also have thresholds which are set seemingly arbitrarily. So just having one pass/fail test which depends on the ERA5 derived error bounds seems sensible enough.
I haven't deleted any of the other tests yet though because it might be nice to keep them around until we make a definite decision to drop them.