update xclim version after merging in newest xclim changes#119
Merged
dgergel merged 28 commits intoClimateImpactLab:mainfrom Nov 2, 2021
Merged
update xclim version after merging in newest xclim changes#119dgergel merged 28 commits intoClimateImpactLab:mainfrom
dgergel merged 28 commits intoClimateImpactLab:mainfrom
Conversation
Member
|
@dgergel Is this still a draft or ready to merge? More work needed? |
Member
Author
|
@brews it's now ready for a review! |
brews
approved these changes
Nov 2, 2021
Member
There was a problem hiding this comment.
Thanks for this update, @dgergel. I think this is ready to merge, but I have two suggested additions.
First, note these changes in HISTORY.rst. I'd note that we updated our fork of xclim to (whatever the latest version is...?) note the breaking changes to dodola's past core and services API's past behavior. I think the only breaking change is requiring a pint-readable units in ds[variable].attrs on input Datasets, right?
Edit:
The second addition is noting where input datasets require variables with units metadata, in docstrs.
And I think you're set to merge this whenever you think it's ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
xclimversion to 0.30.1 in our fork, adds support for 360-day calendars.This PR also adds
breakingchanges for the QDM and AIQPD implementations to make them consistent with the majorxclim0.29 updates and requires that all inputs to QDM and AIQPD have units attributes that are compatible withpintunits.