Add QDM output Zarr priming, region writing, metadata, multi-year processing#129
Merged
brews merged 13 commits intoClimateImpactLab:mainfrom Nov 10, 2021
Merged
Add QDM output Zarr priming, region writing, metadata, multi-year processing#129brews merged 13 commits intoClimateImpactLab:mainfrom
brews merged 13 commits intoClimateImpactLab:mainfrom
Conversation
This is a breaking change. Previously dodola.services.apply_qdm output a NetCDF. Now it writes a Zarr store. The service now can biascorrect multiple years.
This was referenced Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the QDM command prototypes, breaking backward compatibility.
Changes include:
We should then be set to write output to that zarr store, regionally, with regions delimited along the "lat" dimension.
Write to regions of a primed Zarr Store aggressively with
dodola apply-qdm --out-zarr-region. For example,--out-zarr-region "lat=0,2"will write QDM-adjusted output toslice(0, 2)along the "lat" dimension. Note this is written aggressively (withmode="a"), so use caution not to corrupt existing data. Use this with the--selsliceand--iselslicearguments to filter input data.dodola apply-qdmnow expects to be applied to multiple years, rather than single years. It does this through a--yearsargument. It's used like--years=2015,2100. This should help work run faster and more efficiently on spatially regional subsets consuming the entire input time series.Root and variable attributes are now copied from input data to output QDM-adjusted datasets. QDM output should now also match the dtype of the input dataset variable.
QDM's
sim_qare now output as a variable instead of a coordinate. These are now output by default.apply-qdmandprime-qdm-output-zarrstoreboth accept one or more--new-attrsoptions. This is a fast way of adding simple metadata to output. Each of these takekey=valuepairs that are merged into the output Dataset's rootattrsbefore being written.Logging is slightly more chatty on INFO, especially with respect to data slicing.