distinguish missing from excess timesteps in timesteps validation#140
Merged
dgergel merged 3 commits intoClimateImpactLab:mainfrom Nov 29, 2021
Merged
Conversation
brews
approved these changes
Nov 24, 2021
Member
brews
left a comment
There was a problem hiding this comment.
Thanks for this @emileten!
I can live with this if this fits the behavior and level of testing that @dgergel wants for validation. I'm not sure we need to check "historical" like we've done for "future" because we explicitly crop historical at 1950 -- but again, go with her feel on this.
@emileten, please also add an additional commit noting your change in HISTORY.rst. The easiest way is to copy the PR title, and note your PR number and GitHub name. We want to be sure you're credited for your contributions.
Contributor
Author
Member
|
Thanks @emileten! And checking on permissions for you. Merging in the meantime. |
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dgergel this is solving #139. We're (1) raising an exception if the time span is too short, with a slightly lower expectation for
'future' 'cmip6'(2) warning the user if the time span is too long.@brews I don't think there is a test to write, but let me know if I am wrong.
Close #139