Skip to content

Add precip unit conversion#94

Merged
brews merged 5 commits intoClimateImpactLab:mainfrom
dgergel:add_precip_unit_conversion
Jul 2, 2021
Merged

Add precip unit conversion#94
brews merged 5 commits intoClimateImpactLab:mainfrom
dgergel:add_precip_unit_conversion

Conversation

@dgergel
Copy link
Member

@dgergel dgergel commented Jul 1, 2021

This PR adds a units conversion for precip to the CMIP6 cleaning service and updates the test suite a bit such that the unit conversion can be tested.

closes #93

@dgergel dgergel added the enhancement New feature or request label Jul 1, 2021
@dgergel dgergel requested a review from brews July 1, 2021 21:26
Copy link
Member

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dgergel , thanks for cranking this!

First, please add your change to HISTORY.rst, referencing your issue/PR and your name.

I have a few changes I noted inline that I'd strongly recommend and one minor unit quibble.

@dgergel dgergel requested a review from brews July 2, 2021 21:54
Copy link
Member

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgergel Great changes! I

I'm glad those pinned packages resolved those failed tests. That could have been nasty.

This is good to go!

@brews brews merged commit 0ad3449 into ClimateImpactLab:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add precip unit conversion to CMIP6 cleaning

2 participants