Skip to content

🔧 chore: don't use babel-loader and ts-loader concurrently#220

Merged
alexcui03 merged 4 commits into
dev/3.2from
feat/use-babel-preset-ts
Apr 16, 2026
Merged

🔧 chore: don't use babel-loader and ts-loader concurrently#220
alexcui03 merged 4 commits into
dev/3.2from
feat/use-babel-preset-ts

Conversation

@SimonShiki
Copy link
Copy Markdown
Member

Description

don't use babel-loader and ts-loader concurrently.

Proposed Changes

  1. Remove ts-loader for packages that already has babel-loader, and make them use @babel/preset-typescript to handle ts files.

Test Coverage

Existing packages's playground and build pass

Additional Context

None

Signed-off-by: SimonShiki <sinangentoo@gmail.com>
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki requested a review from alexcui03 April 15, 2026 14:25
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 15, 2026

Deploying clipcc-preview with  Cloudflare Pages  Cloudflare Pages

Latest commit: fda1091
Status: ✅  Deploy successful!
Preview URL: https://3a10fc2b.clipcc-preview.pages.dev
Branch Preview URL: https://feat-use-babel-preset-ts.clipcc-preview.pages.dev

View logs

Signed-off-by: SimonShiki <sinangentoo@gmail.com>
Comment thread packages/vm/webpack.config.js Outdated
Comment thread packages/block/webpack.config.js Outdated
Comment thread packages/render/webpack.config.js Outdated
Comment thread packages/storage/webpack.config.js Outdated
Comment thread packages/svg-renderer/webpack.config.js Outdated
@alexcui03
Copy link
Copy Markdown
Member

There exists a problem that @babel/preset-typescript won't check types, then it will be hard to report an error when working with webpack-dev-server. In that way, I'd prefer to use ts-loader for transpiling .ts files.

Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki SimonShiki requested a review from alexcui03 April 16, 2026 00:20
@alexcui03 alexcui03 merged commit 899b8b4 into dev/3.2 Apr 16, 2026
6 checks passed
@alexcui03 alexcui03 deleted the feat/use-babel-preset-ts branch April 16, 2026 04:26
@SimonShiki SimonShiki mentioned this pull request Apr 21, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants