Skip to content

Contract - Extend contract indefinetly #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chgad merged 1 commit into from
Mar 5, 2026
Merged

Contract - Extend contract indefinetly #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions api/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,6 @@ def validate(self, attrs):
)
)

# check if new end date is more than 6 month apart from the old one
if relativedelta(end_date, self.instance.end_date).months >= 6:
raise serializers.ValidationError(
_(
"A contract's end date cannot be modified "
"to extend more than 6 months."
)
)

# no modification of minutes, start_date and carryover with locked shifts
if Shift.objects.filter(contract=self.instance, locked=True).exists():
if self.instance.initial_carryover_minutes != initial_carryover_minutes:
Expand Down
15 changes: 0 additions & 15 deletions api/tests/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,21 +339,6 @@ def test_update_carryover_minutes_and_start_date_correct_evaluated(
assert start_date_changed
assert initial_carryover_minutes_changed

@pytest.mark.freeze_time("2019-1-20")
@pytest.mark.django_db
def test_update_contract_end_date(
self,
contract_end_date_7_months_apart_json,
plain_request_object,
contract_object,
):
with pytest.raises(serializers.ValidationError):
ContractSerializer(
instance=contract_object,
data=contract_end_date_7_months_apart_json,
context={"request": plain_request_object},
).is_valid(raise_exception=True)

@pytest.mark.django_db
def test_carryover_not_modifiable_with_locked_shifts(
self,
Expand Down
Loading