Skip to content

Conversation

@sauravpanda
Copy link
Member

@sauravpanda sauravpanda commented Jun 20, 2024

Summary

Update CLI publishing workflow to use a new PyPI API token for authentication.

Details

  • Updated the PyPI publishing workflow in the '.github/workflows/pypi-publish-cli.yml' file to use a new PyPI API token for CLI publishing.
  • Changed the value of the '--password' argument in the 'poetry publish' command to reference the updated API token variable.

✨ Generated with love by Kaizen ❤️

Original Description None

@kaizen-bot
Copy link
Contributor

kaizen-bot bot commented Jun 20, 2024

Code Review

All Clear: This PR is ready to merge! 👍

Potential Issues

[important] -> Hardcoded sensitive information should be avoided.

Potential Solution:

It's important to avoid hardcoding sensitive information like passwords or API tokens directly into the code. Consider using environment variables or a secret management tool to securely store and retrieve this information.

.github/workflows/pypi-publish-cli.yml | 25 - 25

request_for_change: True

✨ Generated with love by Kaizen ❤️

@sauravpanda sauravpanda merged commit 3f0c405 into main Jun 20, 2024
@cloudcodeai-nightly
Copy link

Code Review

All Clear: This PR is ready to merge! 👍

Potential Issues

[important] -> The password for publishing to PyPI is being hardcoded in the workflow file.

Potential Solution:

Consider using an environment variable or a secret management system to store and retrieve the password securely.

.github/workflows/pypi-publish-cli.yml | 5 - 5

request_for_change: True

✨ Generated with love by Kaizen ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants