Skip to content

[DEV-18680] Set wrapper.region_name#89

Merged
mrobbieb merged 2 commits intomasterfrom
bug/DEV-18680-Fix-S3-Region
Apr 28, 2021
Merged

[DEV-18680] Set wrapper.region_name#89
mrobbieb merged 2 commits intomasterfrom
bug/DEV-18680-Fix-S3-Region

Conversation

@mrobbieb
Copy link
Copy Markdown
Contributor

@mrobbieb mrobbieb commented Apr 27, 2021

Set wrapper.region_name to be resource.s3_bucket_region.

Do this before boto3 client is initialized so that we are sure to use the same region/bucket combination that is exposed on the resource/service level.

Without this, we will often default to ‘us-east-1’ which may or may not be the correct region.

Development Prerequisites

Testing

Follow steps in https://cloudbolt.atlassian.net/browse/DEV-18680 .
For the BP with actions, use
aws_s3_bucket_content_dev.zip . This was got from content-dev.cloudbolt.io using Content Library. I had to curate this a bit since a number of other actions were included on account of Content Dev having many versions of the same action.

This was exported from https://10.55.60.111 which should be accessible. See @Ignacious for login if needed.

Create/List/Delete should work without errors.

mbaker added 2 commits April 27, 2021 13:58
Do this before boto3 client is initialized so that we are sure to use the same region/bucket combination that is exposed on the resource/service level.

Without this, we will often default to ‘us-east-1’ which may or may not be the correct region.
add wrapper.region_name for get_boto3_resource()
move to aws and wrapper syntax which is clearer
Copy link
Copy Markdown
Contributor

@laltomar laltomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown

@jmarco-cloudbolt jmarco-cloudbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@mrobbieb mrobbieb merged commit 4af5780 into master Apr 28, 2021
jwalker-cb added a commit that referenced this pull request Mar 16, 2022
…rkflow

Test automation updates SO MUCH POWER!!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants