feat():[CMP-265] Added support for labels… #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orvisevans
suggested changes
Nov 2, 2023
orvisevans
left a comment
orvisevans
left a comment
There was a problem hiding this comment.
I didn't get quite as deep as I'd like in the time I had, but hopefully this is useful food for thought. I'll give it another pass after you respond to these.
…moved the user store. Changed how api is used after passed in. Changed variable names
…ing emits to handle applet notifications
orvisevans
suggested changes
Nov 2, 2023
…ect, updated variable handling in getAppletsforTarget
orvisevans
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - CMP-265
Engineer - @tropotorres
Added support for labels and pulling specific applets on HUI
Whoops, sorry this kind of exploded with the formatting changes.
**Summary of updates:**
^(Probably one of the things to look at the most)
- Also updated 'getAppletsForTarget' to use the targetId (aka the applet "id") if it is passed in to narrow the list of applets (+ updated tests)