Fixed issue #218#219
Closed
sindastra wants to merge 3 commits intoCloudBotIRC:python3.4from
Closed
Conversation
Update README.md
Fixed regular expression Fixed typo Updated return messages to include the channel
Contributor
|
I'm going to slightly change the wording here: the current message implies that the last time the person talked in any channel was in the specified channel, while that's not at all what the command is returning. Besides that, thanks! PR will be merged. |
Contributor
|
Merged in 601e9a6. |
linuxdaemon
pushed a commit
to linuxdaemon/CloudBot
that referenced
this pull request
Nov 14, 2017
…-fix Properly start the botwide observer on start
linuxdaemon
added a commit
to linuxdaemon/CloudBot
that referenced
this pull request
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed issue #218, a regular expression, a typo and updated the return messages.