Merged
Conversation
ghost
changed the title
Contributor
|
I... guess this works. Ideally we would want to check if the optional things are in the result with the |
linuxdaemon
pushed a commit
to linuxdaemon/CloudBot
that referenced
this pull request
Jun 30, 2018
Bumps [geoip2](https://github.com/maxmind/GeoIP2-python) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/maxmind/GeoIP2-python/releases) - [Changelog](https://github.com/maxmind/GeoIP2-python/blob/master/HISTORY.rst) - [Commits](maxmind/GeoIP2-python@v2.8.0...v2.9.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
daboross
approved these changes
Dec 10, 2018
Contributor
daboross
left a comment
daboross
left a comment
There was a problem hiding this comment.
I've tested this and it has no ill effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented simple try/except blocks for a few variables in youtube.py -- catches the raised exception and still prints the title but with N/A as like/dislike/percentage.