chatbot.py - Using while loops#56
Merged
dmptrluke merged 2 commits intoCloudBotIRC:python3.4from Jan 10, 2015
Merged
Conversation
Contributor
|
Not sure, but I think it might be a good idea to have this in a for loop repeating 5-10 times rather than a while loop, just because we don't want plugins hanging indefinitely if something goes wrong. |
Member
Author
|
If that's the case, a timeout value can be added and checked against, to prevent a hanging module. |
Member
|
Or a simple limit on loop iterations On Sun, Jan 11, 2015 at 12:17 PM, Foxlet notifications@github.com wrote:
|
Member
|
Ah, you did do that, I was confused by the message. |
dmptrluke
added a commit
that referenced
this pull request
Jan 10, 2015
chatbot.py - Using while loops
linuxdaemon
pushed a commit
to linuxdaemon/CloudBot
that referenced
this pull request
Dec 23, 2016
spotify.py commands updated to use the new spotify API
linuxdaemon
pushed a commit
to linuxdaemon/CloudBot
that referenced
this pull request
May 7, 2017
Add .kebab command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using while statements make more sense if we get only one ad or more than two.