Skip to content

chatbot.py - Using while loops#56

Merged
dmptrluke merged 2 commits intoCloudBotIRC:python3.4from
FurCode:python3.4
Jan 10, 2015
Merged

chatbot.py - Using while loops#56
dmptrluke merged 2 commits intoCloudBotIRC:python3.4from
FurCode:python3.4

Conversation

@foxlet
Copy link
Copy Markdown
Member

@foxlet foxlet commented Jan 10, 2015

Using while statements make more sense if we get only one ad or more than two.

@daboross
Copy link
Copy Markdown
Contributor

Not sure, but I think it might be a good idea to have this in a for loop repeating 5-10 times rather than a while loop, just because we don't want plugins hanging indefinitely if something goes wrong.

@foxlet
Copy link
Copy Markdown
Member Author

foxlet commented Jan 10, 2015

If that's the case, a timeout value can be added and checked against, to prevent a hanging module.

@dmptrluke
Copy link
Copy Markdown
Member

Or a simple limit on loop iterations

On Sun, Jan 11, 2015 at 12:17 PM, Foxlet notifications@github.com wrote:

If that's the case, a timeout value can be added and checked against, to
prevent a hanging module.


Reply to this email directly or view it on GitHub
#56 (comment).

@dmptrluke
Copy link
Copy Markdown
Member

Ah, you did do that, I was confused by the message.

dmptrluke added a commit that referenced this pull request Jan 10, 2015
chatbot.py - Using while loops
@dmptrluke dmptrluke merged commit c950c54 into CloudBotIRC:python3.4 Jan 10, 2015
linuxdaemon pushed a commit to linuxdaemon/CloudBot that referenced this pull request Dec 23, 2016
spotify.py commands updated to use the new spotify API
linuxdaemon pushed a commit to linuxdaemon/CloudBot that referenced this pull request May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants