Skip to content

fix: remove invalid service annotations #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derklaro merged 1 commit into from
Aug 24, 2025
Merged

fix: remove invalid service annotations #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...s/npcs/impl/src/main/java/eu/cloudnetservice/modules/npc/impl/node/CloudNetNPCModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import eu.cloudnetservice.driver.module.ModuleLifeCycle;
import eu.cloudnetservice.driver.module.ModuleTask;
import eu.cloudnetservice.driver.module.driver.DriverModule;
import eu.cloudnetservice.driver.registry.Service;
import eu.cloudnetservice.modules.npc.NPC;
import eu.cloudnetservice.modules.npc.NPCManagement;
import eu.cloudnetservice.modules.npc.configuration.InventoryConfiguration;
Expand Down Expand Up @@ -202,7 +201,7 @@ public void initModule(
}

@ModuleTask(lifecycle = ModuleLifeCycle.RELOADING)
public void handleReload(@Nullable @Service NPCManagement management) {
public void handleReload(@Nullable NPCManagement management) {
if (management != null) {
management.npcConfiguration(this.loadConfig());
}
Expand Down
5 changes: 2 additions & 3 deletions ...ns/impl/src/main/java/eu/cloudnetservice/modules/signs/impl/node/CloudNetSignsModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import eu.cloudnetservice.driver.module.ModuleLifeCycle;
import eu.cloudnetservice.driver.module.ModuleTask;
import eu.cloudnetservice.driver.module.driver.DriverModule;
import eu.cloudnetservice.driver.registry.Service;
import eu.cloudnetservice.driver.registry.ServiceRegistry;
import eu.cloudnetservice.driver.service.ServiceEnvironmentType;
import eu.cloudnetservice.modules.bridge.WorldPosition;
Expand Down Expand Up @@ -103,7 +102,7 @@ public void handleInitialization(
@ModuleTask(order = 20)
public void handleDatabaseConvert(
@NonNull DatabaseProvider databaseProvider,
@NonNull @Service SignManagement signManagement
@NonNull SignManagement signManagement
) {
this.convertDatabaseIfNecessary(databaseProvider, signManagement);
}
Expand All @@ -114,7 +113,7 @@ public void handleStopping() throws Exception {
}

@ModuleTask(lifecycle = ModuleLifeCycle.RELOADING)
public void handleReload(@Nullable @Service SignManagement management) {
public void handleReload(@Nullable SignManagement management) {
if (management != null) {
management.signsConfiguration(NodeSignsConfigurationHelper.read(this.configPath()));
}
Expand Down
Loading