Skip to content

Conversation

@derklaro
Copy link
Member

Motivation

The onlinePlayerAsync method was accidentially renamed to onlinePlayersAsync, this should be reverted.

Modification

Rename onlinePlayersAsync to onlinePlayerAsync.

Result

The method has the correct name again.

@derklaro derklaro added this to the 4.0.0-RC15 milestone Oct 13, 2025
@derklaro derklaro requested a review from 0utplay October 13, 2025 15:45
@derklaro derklaro self-assigned this Oct 13, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules a: api An issue/pull request that is related to api changes. labels Oct 13, 2025
@github-actions
Copy link

Test Results

 56 files  ±0   56 suites  ±0   4m 12s ⏱️ +12s
570 tests ±0  570 ✅ ±0  0 💤 ±0  0 ❌ ±0 
937 runs  ±0  937 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2aa0fde. ± Comparison against base commit 7630f6a.

@derklaro derklaro merged commit de0f24d into nightly Oct 14, 2025
6 checks passed
@derklaro derklaro deleted the online-player-async branch October 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: api An issue/pull request that is related to api changes. in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants