Merged
Conversation
Adds the option to use fuzzy matching when filtering menu items. Port of https://tools.suckless.org/dmenu/patches/fuzzymatch/dmenu-fuzzymatch-4.6.diff
|
Bumping this, totally works and no issues |
|
@Cloudef could you review this please? |
Owner
|
Sorry for taking so long. It looks good to me. |
Contributor
Author
|
thank you! |
Owner
|
Hello, I reverted these changes because static analysis found bugs in the code. The CI probably did not find those because it was running older version of the compiler at the time of PR. Also, I think this feature should be implemented as separate function rather than in the default filter_dmenu_fun as dmenu has mechanism for selectable filters here https://github.com/Cloudef/bemenu/blob/master/lib/menu.c#L44-L47. If you send a revised PR, I'll review it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to use fuzzy matching when filtering menu items, along with the necessary flag and usage info.
Port of / strongly inspired by: https://tools.suckless.org/dmenu/patches/fuzzymatch/dmenu-fuzzymatch-4.6.diff
Would close #367