Skip to content

feat: integrate profile secret resolver in backup and store flows#107

Merged
rmanibus merged 1 commit into
mainfrom
feat/rfc0011-profile-resolver-integration
Mar 15, 2026
Merged

feat: integrate profile secret resolver in backup and store flows#107
rmanibus merged 1 commit into
mainfrom
feat/rfc0011-profile-resolver-integration

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Summary

What Changed

  • Added shared helper: cmd/cloudstic/profile_secret.go
    • resolveProfileStoreValue(field, direct, secretRef, envName)
    • returns actionable field-scoped errors on bad refs
  • Updated backup profile merge path:
    • applyProfileStoreToGlobalFlags now returns errors
    • resolves *_secret values (with legacy env fallback)
    • merge path surfaces contextual errors: profile <name> store <ref>: ...
  • Updated store runtime path:
    • globalFlagsFromProfileStore now returns (*globalFlags, error)
    • checkOrInitStore reports credential resolution errors early
  • Updated global profile override path in store.go to propagate errors.
  • Added precedence and failure tests in:
    • cmd/cloudstic/cmd_backup_profile_test.go
    • cmd/cloudstic/cmd_store_test.go

Validation

  • go test ./...
  • golangci-lint run ./...

Tracking

@rmanibus rmanibus added the enhancement New feature or request label Mar 15, 2026
@rmanibus rmanibus force-pushed the feat/rfc0011-profile-resolver-integration branch from 1da1776 to 40b8421 Compare March 15, 2026 18:10
@rmanibus rmanibus merged commit f34342a into main Mar 15, 2026
4 checks passed
@rmanibus rmanibus deleted the feat/rfc0011-profile-resolver-integration branch March 15, 2026 18:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 55.69620% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/cloudstic/cmd_store.go 43.33% 9 Missing and 8 partials ⚠️
cmd/cloudstic/cmd_backup.go 55.55% 8 Missing and 8 partials ⚠️
cmd/cloudstic/store.go 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 0011: Integrate secret resolver into backup/store profile resolution

1 participant