Skip to content

fix: harden curl installer edge cases#119

Merged
rmanibus merged 1 commit into
mainfrom
fix/installer-followup-from-pr114
Mar 16, 2026
Merged

fix: harden curl installer edge cases#119
rmanibus merged 1 commit into
mainfrom
fix/installer-followup-from-pr114

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Summary

Follow-up to review concerns raised on merged PR #114 (and related installer docs from #115).

  • Harden installer failure handling for non-writable install directories:
    • handle mkdir -p failure explicitly with actionable guidance
    • preserve and print real cp/chmod errors instead of always reporting "permission denied"
  • Add explicit awk dependency check since the script relies on it.
  • Normalize --version values so both v1.2.3 and 1.2.3 work.
  • Expand docs with a documented --no-verify escape hatch.
  • Improve manual pre-built binary example with explicit checksum verification and note preferring the installer.

Validation

  • sh -n scripts/install.sh
  • ./scripts/install.sh --help

Context

These changes address unresolved review feedback from:

@rmanibus rmanibus linked an issue Mar 16, 2026 that may be closed by this pull request
@rmanibus rmanibus merged commit df72a6c into main Mar 16, 2026
5 checks passed
@rmanibus rmanibus deleted the fix/installer-followup-from-pr114 branch March 16, 2026 08:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus added the bug Something isn't working label Mar 16, 2026
@rmanibus rmanibus added this to the v1.12.0 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer follow-ups: curl script and completion UX

1 participant