fix: follow up on creds resolver review concerns#120
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for unresolved review concerns left on merged PR #110.
security ... -winnativeSecretExists(prevents secret value from being printed)promptSecretnow trims only trailing newlines (\r\n) instead of all surrounding whitespaceenv://andkeychain://wincred://...andsecret-service://...are documented as planned (not yet available in default resolver)Legacy *-env flags...Validation
go test -count=1 ./cmd/cloudstic -run 'TestNativeSecretExists|TestSaveSecretToNativeStore|TestCompletionBash|TestCompletionZsh|TestCompletionFish|TestPromptSecretReference'go test -count=1 ./...golangci-lint run ./...Context
This PR is a follow-up to comments on merged PR #110.