Skip to content

fix: follow up on creds resolver review concerns#120

Merged
rmanibus merged 2 commits into
mainfrom
fix/pr110-followup-concerns
Mar 16, 2026
Merged

fix: follow up on creds resolver review concerns#120
rmanibus merged 2 commits into
mainfrom
fix/pr110-followup-concerns

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Summary

Follow-up fixes for unresolved review concerns left on merged PR #110.

  • Harden macOS keychain existence checks:
    • stop using security ... -w in nativeSecretExists (prevents secret value from being printed)
    • discard stdout and surface non-"not found" errors with context
  • Preserve intentional whitespace in interactive secret entry:
    • promptSecret now trims only trailing newlines (\r\n) instead of all surrounding whitespace
  • Align help/docs with actually supported default secret-ref schemes:
    • usage/docs now list env:// and keychain://
    • wincred://... and secret-service://... are documented as planned (not yet available in default resolver)
  • Fix small usage wording typo: Legacy *-env flags...

Validation

  • go test -count=1 ./cmd/cloudstic -run 'TestNativeSecretExists|TestSaveSecretToNativeStore|TestCompletionBash|TestCompletionZsh|TestCompletionFish|TestPromptSecretReference'
  • go test -count=1 ./...
  • golangci-lint run ./...

Context

This PR is a follow-up to comments on merged PR #110.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/cloudstic/usage.go 0.00% 8 Missing ⚠️
cmd/cloudstic/interactive.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus changed the title fix: follow up on PR110 review concerns fix: follow up on creds resolver review concerns Mar 16, 2026
@rmanibus rmanibus merged commit fbad190 into main Mar 16, 2026
5 of 6 checks passed
@rmanibus rmanibus deleted the fix/pr110-followup-concerns branch March 16, 2026 08:33
@rmanibus rmanibus added the bug Something isn't working label Mar 16, 2026
@rmanibus rmanibus linked an issue Mar 16, 2026 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 0011: Epic / Tracking issue for profile credential storage backends

1 participant