Skip to content

fix: gate macOS keychain code behind cgo#124

Merged
rmanibus merged 1 commit into
mainfrom
fix/release-darwin-cgo-tags
Mar 16, 2026
Merged

fix: gate macOS keychain code behind cgo#124
rmanibus merged 1 commit into
mainfrom
fix/release-darwin-cgo-tags

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Summary

  • restrict macOS keychain implementations and tests to darwin && cgo
  • use the existing stub implementations for darwin && !cgo so GoReleaser can cross-compile macOS targets from Linux
  • fix the release failure caused by cross-compiling darwin binaries without the go-keychain cgo-backed symbols available

Verification

  • GOOS=darwin GOARCH=amd64 go build ./cmd/cloudstic
  • GOOS=darwin GOARCH=arm64 go build ./cmd/cloudstic
  • go test ./internal/secretref ./cmd/cloudstic

@rmanibus rmanibus merged commit 13684fd into main Mar 16, 2026
4 checks passed
@rmanibus rmanibus deleted the fix/release-darwin-cgo-tags branch March 16, 2026 10:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus added the bug Something isn't working label Mar 17, 2026
@rmanibus rmanibus added this to the v1.12.0 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant