fix: build macOS releases with keychain support#125
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Updates the release pipeline to ship macOS binaries built with CGO enabled so the real Keychain backend is included in Homebrew-installed artifacts, while keeping Linux/Windows builds cross-compiled with CGO_ENABLED=0.
Changes:
- Split GoReleaser builds into
cloudstic-cross(Linux/Windows,CGO_ENABLED=0) andcloudstic-darwin(macOS,CGO_ENABLED=1). - Move the GitHub Actions release job to a native
macos-latestrunner to support CGO-based macOS builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.goreleaser.yml |
Separates darwin builds to enable CGO for Keychain support while keeping cross builds CGO-free. |
.github/workflows/release.yml |
Runs the release job on macOS so GoReleaser can build darwin artifacts with CGO enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CGO_ENABLED=0while Darwin builds useCGO_ENABLED=1darwin && !cgostubVerification
CGO_ENABLED=1 go build ./cmd/cloudsticGOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build ./cmd/cloudsticGOOS=windows GOARCH=arm64 CGO_ENABLED=0 go build ./cmd/cloudsticgo test ./internal/secretref ./cmd/cloudsticContext
The previous release fix made cross-compiled macOS builds fall back to the stub keychain implementation so GoReleaser could succeed on Linux. That avoided the release failure, but it also meant Homebrew-installed macOS binaries could not use
keychain://...secret refs. This change restores native Keychain support in macOS release artifacts.