Skip to content

refactor: share writable native secret backends (RFC 0011)#140

Merged
rmanibus merged 2 commits into
mainfrom
feat/shared-writable-secret-backends
Mar 17, 2026
Merged

refactor: share writable native secret backends (RFC 0011)#140
rmanibus merged 2 commits into
mainfrom
feat/shared-writable-secret-backends

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Closes #138

Summary

  • move native secret write and exists behavior into shared internal/secretref writable backend capabilities
  • refactor macOS keychain write support to live with the keychain backend instead of CLI-local helper files
  • update interactive store prompting to use writable backend capabilities rather than hard-coded platform-specific secret store helpers

Testing

  • go test ./internal/secretref ./cmd/cloudstic
  • golangci-lint run ./internal/secretref/... ./cmd/cloudstic/...

@rmanibus rmanibus changed the title refactor: share writable native secret backends refactor: share writable native secret backends (RFC 0011) Mar 17, 2026
@rmanibus rmanibus merged commit b7973d4 into main Mar 17, 2026
6 checks passed
@rmanibus rmanibus deleted the feat/shared-writable-secret-backends branch March 17, 2026 20:44
@rmanibus rmanibus added the chore Maintenance and tooling changes label Mar 17, 2026
@rmanibus rmanibus added this to the v1.13.0 milestone Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 63.11475% with 45 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/secretref/secretref.go 56.25% 14 Missing and 7 partials ⚠️
internal/secretref/keychain_backend.go 53.65% 15 Missing and 4 partials ⚠️
internal/secretref/keychain_backend_stub.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus added refactor and removed chore Maintenance and tooling changes labels Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 0011: Refactor native secret writes into shared backend abstraction

1 participant