Skip to content

feat: restore xattrs in directory restores#143

Merged
rmanibus merged 2 commits into
mainfrom
feat/restore-dir-xattrs
Mar 17, 2026
Merged

feat: restore xattrs in directory restores#143
rmanibus merged 2 commits into
mainfrom
feat/restore-dir-xattrs

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Closes #139

Summary

  • replay stored extended attributes during direct-to-filesystem restores for files and directories on Unix platforms
  • treat unsupported or permission-denied xattr writes as best-effort while still surfacing unexpected xattr restore failures
  • add unit and restore-flow coverage for xattr replay behavior

Testing

  • go test ./internal/engine ./cmd/cloudstic
  • golangci-lint run ./internal/engine/... ./cmd/cloudstic/...

@rmanibus rmanibus merged commit 702e294 into main Mar 17, 2026
6 checks passed
@rmanibus rmanibus deleted the feat/restore-dir-xattrs branch March 17, 2026 21:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/engine/restore.go 0.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus added the enhancement New feature or request label Mar 18, 2026
@rmanibus rmanibus added this to the v1.13.0 milestone Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 0006: Restore extended file attributes in direct-to-filesystem restores

1 participant