Skip to content

fix: canonicalize relative local source paths#146

Merged
rmanibus merged 1 commit into
mainfrom
fix/local-source-relative-path-canonicalization
Mar 18, 2026
Merged

fix: canonicalize relative local source paths#146
rmanibus merged 1 commit into
mainfrom
fix/local-source-relative-path-canonicalization

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

Closes #145

Summary

  • avoid deriving bogus volume-relative local source paths when the resolved source path is not actually under the detected mount root
  • keep local:./ and similar relative roots persisted as canonical absolute paths when no safe relative path exists
  • add regression coverage for the broken relative-root case and the root-containment helper

Testing

  • go test ./pkg/source ./cmd/cloudstic

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/source/local_source.go 58.82% 4 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus merged commit ea3fdd5 into main Mar 18, 2026
6 of 7 checks passed
@rmanibus rmanibus deleted the fix/local-source-relative-path-canonicalization branch March 18, 2026 08:13
@rmanibus rmanibus added the bug Something isn't working label Mar 18, 2026
@rmanibus rmanibus added this to the v1.13.0 milestone Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix local source path canonicalization for relative roots

1 participant