feat: add WithDriveService, WithCredsJSON and --google-credentials-json flag#177
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…on flag Add two new GDrive source options for improved flexibility: - WithDriveService: inject a pre-built *drive.Service (for library users managing auth externally via ADC, custom TokenSource, etc.) - WithCredsJSON: provide credentials as inline JSON bytes (mirrors rclone's service_account_credentials option) Add --google-credentials-json CLI flag and GOOGLE_CREDENTIALS_JSON env var so inline credential JSON can be provided without mounting files (ideal for CI/CD and containerised environments). Wire through profiles and auth entries. Refactor the auth logic in NewGDriveSource: extract buildDriveService, loadCredsBytes, serviceFromCredsBytes, and resolveDriveName helpers. The constructor drops from ~120 lines to ~50 with clear early-return priority: 1. Pre-built service (WithDriveService) 2. Custom HTTP client (WithHTTPClient) 3. Explicit credentials (inline JSON > secret ref > file path) 4. Built-in default OAuth client Update user guide with credential documentation and env var table.
rmanibus
force-pushed
the
feat/gdrive-credentials-flexibility
branch
from
0e18ea8 to
47059c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new GDrive source options for improved flexibility:
Add --google-credentials-json CLI flag and GOOGLE_CREDENTIALS_JSON env var so inline credential JSON can be provided without mounting files (ideal for CI/CD and containerised environments). Wire through profiles and auth entries.
Refactor the auth logic in NewGDriveSource: extract buildDriveService, loadCredsBytes, serviceFromCredsBytes, and resolveDriveName helpers. The constructor drops from ~120 lines to ~50 with clear early-return priority:
Update user guide with credential documentation and env var table.