Skip to content

fix: allow filter-only forget runs#183

Merged
rmanibus merged 3 commits into
mainfrom
forget-filter-pr
Apr 2, 2026
Merged

fix: allow filter-only forget runs#183
rmanibus merged 3 commits into
mainfrom
forget-filter-pr

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

@rmanibus rmanibus commented Apr 2, 2026

Summary

  • allow forget policy mode to run with filters only, without requiring keep flags
  • validate that snapshot_id is not combined with retention or filter flags
  • add focused CLI and engine test coverage for the new argument handling

Testing

  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./cmd/cloudstic -run TestRunForget|TestValidateForgetArgs
  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./internal/engine -run Test.*Forget

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/cloudstic/cmd_forget.go 71.11% 7 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus merged commit 8275cd4 into main Apr 2, 2026
10 checks passed
@rmanibus rmanibus deleted the forget-filter-pr branch April 2, 2026 10:00
@rmanibus rmanibus added this to the v1.14.0 milestone Apr 2, 2026
@rmanibus rmanibus added the enhancement New feature or request label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant