Skip to content

fix: stabilize SFTP known_hosts generation in tests#186

Merged
rmanibus merged 1 commit into
mainfrom
fix-sftp-known-hosts-ci
Apr 2, 2026
Merged

fix: stabilize SFTP known_hosts generation in tests#186
rmanibus merged 1 commit into
mainfrom
fix-sftp-known-hosts-ci

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

@rmanibus rmanibus commented Apr 2, 2026

Summary

  • stop hand-building known_hosts lines in SFTP test helpers
  • parse container host public keys with ssh.ParseAuthorizedKey
  • generate canonical known_hosts entries with knownhosts.Line for e2e and package SFTP tests

Why

The ubuntu CI failure on main was caused by a malformed known_hosts entry in the SFTP test fixture, which broke the sftp-to-sftp integrity scenario during init.

Validation

  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./e2e -run 'TestCLI_Feature_IntegrityCheck'
  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./pkg/store ./pkg/source -run 'TestSFTP(Store|Source)'
  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache golangci-lint run ./e2e ./pkg/store ./pkg/source

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus added this to the v1.14.0 milestone Apr 2, 2026
@rmanibus rmanibus added the chore Maintenance and tooling changes label Apr 2, 2026
@rmanibus rmanibus merged commit 778a38a into main Apr 2, 2026
11 checks passed
@rmanibus rmanibus deleted the fix-sftp-known-hosts-ci branch April 2, 2026 11:29
@rmanibus rmanibus added test and removed chore Maintenance and tooling changes labels Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant