Skip to content

Implement RFC 0015 filemeta path normalization#188

Merged
rmanibus merged 1 commit into
mainfrom
issue-131-filemeta-path-normalization
Apr 2, 2026
Merged

Implement RFC 0015 filemeta path normalization#188
rmanibus merged 1 commit into
mainfrom
issue-131-filemeta-path-normalization

Conversation

@rmanibus
Copy link
Copy Markdown
Contributor

@rmanibus rmanibus commented Apr 2, 2026

Summary

  • stop persisting FileMeta.Paths in newly written filemeta objects and omit empty paths from JSON
  • add shared derived-path helpers so restore, diff, and incremental backup path reconstruction do not depend on stored paths
  • add mixed old/new snapshot compatibility coverage and mark RFC 0015 as implemented

Closes #131.

Testing

  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./internal/engine ./internal/core
  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./cmd/cloudstic
  • env GOCACHE=/tmp/cloudstic-gocache GOMODCACHE=/tmp/cloudstic-gomodcache go test -count=1 ./... (fails in sandbox at internal/retry.TestClassifyHTTPResponse_Integration because httptest cannot bind a local port: listen tcp6 [::1]:0: bind: operation not permitted)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 86.41975% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/engine/diff.go 80.00% 3 Missing and 3 partials ⚠️
internal/engine/filemeta_paths.go 89.18% 2 Missing and 2 partials ⚠️
internal/engine/backup_scan.go 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rmanibus rmanibus merged commit 6cde361 into main Apr 2, 2026
12 checks passed
@rmanibus rmanibus deleted the issue-131-filemeta-path-normalization branch April 2, 2026 13:50
@rmanibus rmanibus added the enhancement New feature or request label Apr 2, 2026
@rmanibus rmanibus added this to the v1.14.0 milestone Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 0015: Epic / Tracking issue for FileMeta path normalization

1 participant