Add indices on history table foreign keys#32
Merged
Conversation
Tweak: Add indices on history table foreign keys
Contributor
|
LGTM |
Contributor
|
tests run pretty fast here |
multigl
approved these changes
Aug 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only relevant for UUID columns, but results in some expensive joins. The way we build the GiST indices on history tables means we don't have any implicit index on the entity foreign key the way we do with the clock table. This adds an explicit index so you don't have to remember to cast your UUID primary keys to text when joining to column history.
Without casts. Note that the index scan only uses the vclock portion of the exclusion constraint and triggers an expensive join filter:
With casts! If we join on the UUIDs casted to text, we're back to being efficient: