Skip to content

Unbreak Sphinx search for ZFS - fixes 437#468

Merged
itamarst merged 3 commits intomasterfrom
sphinx-search-437
Aug 7, 2014
Merged

Unbreak Sphinx search for ZFS - fixes 437#468
itamarst merged 3 commits intomasterfrom
sphinx-search-437

Conversation

@itamarst
Copy link
Copy Markdown
Contributor

@itamarst itamarst commented Aug 6, 2014

Fixes #437.

@exarkun exarkun added the review label Aug 6, 2014
@adamtheturtle
Copy link
Copy Markdown
Contributor

Another option which seems better, on the surface at least, is to use http://sphinxcontrib-spelling.readthedocs.org/ which allows you to have a text file with words "known to be spelled correctly but that do not appear in the language dictionary selected by spelling_lang".

Your solution seems to work for ZFS at least, but may have bad side effects - I assume that there is some reason to omit words shorter than 3 characters, and the sphinxcontrib.spelling seems neater to me. Choose whether to look into sphinxcontrib.spelling and resubmit, or merge now and make an issue, thanks.

@itamarst
Copy link
Copy Markdown
Contributor Author

itamarst commented Aug 7, 2014

Spell checking isn't really the same as search. I filed some tickets to add spell checking though.

itamarst added a commit that referenced this pull request Aug 7, 2014
Unbreak Sphinx search for ZFS

Fixes #437.
@itamarst itamarst merged commit e193d24 into master Aug 7, 2014
@itamarst itamarst deleted the sphinx-search-437 branch August 7, 2014 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation search doesn't always work

3 participants