Skip to content

Fix: bootstrap: ssh public key should be copied to qnetd node when ssh-agent feature is not enabled (bsc#1228950) #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fix: bootstrap: ssh public key should be copied to qnetd node when ssh-agent feature is not enabled (bsc#1228950) #1516

merged 3 commits into from
Aug 30, 2024

Conversation

@nicholasyang2022
Copy link
Collaborator

@nicholasyang2022
Fix: bootstrap: should check if sudo is available when running `clust…
2030d23 
…er init -N` with a non-root destination user (bsc#1228950)
@nicholasyang2022
Fix: bootstrap: should check if sudo is available when running `clust…
2cd0834 
…er join -c` with a non-root destination user (bsc#1228950)
@nicholasyang2022
Fix: bootstrap: drop environ SSH_AUTH_SOCK before checking passwordle…
33cd377 
…ss ssh when it is not enabled (bsc#1228950)

Or local generated keys will not be added to authorized_keys, and future
operations will fail when ssh-agent is not provided any longer.
@codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (49aeacf) to head (33cd377).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/bootstrap.py 40.90% 13 Missing ⚠️
crmsh/utils.py 90.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.24% <56.25%> (+<0.01%) ⬆️
unit 52.45% <40.62%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/utils.py 68.30% <90.00%> (+0.03%) ⬆️
crmsh/bootstrap.py 88.66% <40.90%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review August 15, 2024 08:15
@liangxin1300 liangxin1300 merged commit 951595d into ClusterLabs:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicholasyang2022 @liangxin1300