Fix: corosync: fix linknumber validation (#1546)

crmsh/corosync.py

@@ -682,7 +682,7 @@ def update_link(self, linknumber: int, options: dict[str, str|None]) -> dict:
         Returns: updated configuration dom. The internal state of LinkManager is also updated.
         """
         links = self.links()
-        if links[linknumber] is None:
+        if linknumber >= KNET_LINK_NUM_LIMIT or links[linknumber] is None:
             raise ValueError(f'Link {linknumber} does not exist.')
         if 'nodes' in options:
             raise ValueError('Unknown option "nodes".')
@@ -735,7 +735,7 @@ def update_node_addr(self, linknumber: int, node_addresses: typing.Mapping[int,
         Returns: updated configuration dom. The internal state of LinkManager is also updated.
         """
         links = self.links()
-        if links[linknumber] is None:
+        if linknumber >= KNET_LINK_NUM_LIMIT or links[linknumber] is None:
             raise ValueError(f'Link {linknumber} does not exist.')
         return self.__upsert_node_addr_impl(self._config, links, linknumber, node_addresses)
 
@@ -804,7 +804,7 @@ def remove_link(self, linknumber: int) -> dict:
         Returns: updated configuration dom. The internal state of LinkManager is also updated.
         """
         links = self.links()
-        if links[linknumber] is None:
+        if linknumber >= KNET_LINK_NUM_LIMIT or links[linknumber] is None:
             raise ValueError(f'Link {linknumber} does not exist.')
         if sum(1 if link is not None else 0 for link in links) <= 1:
             raise ValueError(f'Cannot remove the last link.')

crmsh/ui_corosync.py

@@ -96,7 +96,7 @@ def __parse_linknumber(args: typing.Sequence[str], i: int):
         try:
             return int(args[i])
         except ValueError:
-            raise SyntaxError(f'expected linknumber, actual {args[i]}')
+            raise LinkArgumentParser.SyntaxException(f'expected linknumber, actual {args[i]}')
 
     @staticmethod
     def __parse_node_spec(args: typing.Sequence[str], i: int):