Skip to content

Conversation

@liangxin1300
Copy link
Collaborator

Combine "filter_report" and "filter" into one filter

Fix issue #1607

Combine "filter_report" and "filter" into one filter

Fix issue ClusterLabs#1607
@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.25%. Comparing base (a052c25) to head (930258c).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 54.49% <100.00%> (-0.02%) ⬇️
unit 52.15% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/log.py 70.00% <100.00%> (-0.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review November 11, 2024 03:43
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangxin1300 liangxin1300 merged commit a27e5ec into ClusterLabs:master Nov 11, 2024
32 checks passed
liangxin1300 added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants