Convert attrd_updater to use glib for command line handling#2664
Merged
kgaillot merged 6 commits intoClusterLabs:mainfrom Mar 28, 2022
Merged
Convert attrd_updater to use glib for command line handling#2664kgaillot merged 6 commits intoClusterLabs:mainfrom
kgaillot merged 6 commits intoClusterLabs:mainfrom
Conversation
|
retest this please |
kgaillot
reviewed
Mar 25, 2022
|
|
||
| { "lifetime", 'l', 0, G_OPTION_ARG_STRING, &options.attr_section, | ||
| "(Not yet implemented) Lifetime of the node attribute (silently\n" | ||
| INDENT "ignored by cluster)", |
This includes having a done: label at the end of main, calling pcmk__output_and_clear_error, and using GError instead of printing to stderr.
Also, use bool and true/false instead of their glib counterparts where possible.
clumens
force-pushed
the
attrd_updated-glib
branch
from
2d95818 to
378a1a6
Compare
|
Cool to see things getting in shape :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.