Fix: schemas: Use fence-event-2.15.rng #2709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No content changes Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
The move to fence-event-2.15.rng (46dd9b7) did not include updates to the crm_mon and stonith_admin schemas. As a result, the API result fails to validate if it contains a fence event with an exit-reason. Resolves: RHBZ#2086230 Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Contributor
Author
|
This isn't the first time an incomplete schema update has caused a regression. (I broke the alerts schema once.) I wonder if we can automate the propagation of updates. It would take some effort but could save some headaches down the road. |
|
Doh :( Yes, I was thinking the same thing. I'm thinking make in xml/ should fail if there are any mismatches. We'll probably need to move all the current makefile logic into a script, but it's already overly complicated for a makefile anyway. The issue is in the current release candidate, so this should go into the 2.1 branch. I've got a PR for rc2 pending right now, so I'll just close this and add the commits to that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to fence-event-2.15.rng (46dd9b7) did not include updates to the crm_mon and stonith_admin schemas. As a result, the API result fails to validate if it contains a fence event with an exit-reason.
This can cause commands like
pcs node standbyandpcs configto fail after a rolling upgrade when there is a fence event with an exit reason in the history.Resolves: RHBZ#2086230