feat(ui): paint card Base button red when a custom Base Url is set#26
Merged
Conversation
Setting a non-OpenAI Base Url breaks ChatGPT / OAuth accounts because the OAuth callback can't reach the redirected endpoint. The Base button on each card looks identical whether a custom Base Url is set or not, which makes it easy to forget that "this profile's Base Url is overridden" state when switching. Visual signal: - Reuse the existing `profile-action-button-danger` styling (soft red border + hover background) on the Base button when `profile.openai_base_url` is non-null. No new CSS — the variable themes already pick this up. - Tooltip swaps to the new `profileBaseConfigured` copy explaining the OAuth-breakage risk and the suggested workaround (clear the Base Url before switching to a ChatGPT / OAuth account). Locale: zh-CN + en strings added. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 9, 2026
Owner
Author
本地 3-agent review 汇总(pre-push)按 各 agent 共识
唯一观察(不阻塞)
剩余在你侧
🤖 review summary by Claude Code |
This was referenced May 9, 2026
Cmochance
added a commit
that referenced
this pull request
May 9, 2026
Bumps package.json to 1.5.7 (and lets `version-sync.mjs` propagate to Cargo.toml + Cargo.lock + package-lock.json) and adds the 1.5.7 CHANGELOG entry covering #26, #29, #30, #31: - #29 critical: PID-reuse race + buffer-fill hang in login cancel - #26 baseurl button red warning style - #30 InstallState + codex CLI helpers refactor to shared - #31 a11y aria-label + bounded mac PATH probe Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Visual cue on each profile card: the Base button turns red whenever a custom Base Url is set on that profile.
Why
A non-OpenAI Base Url breaks ChatGPT / OAuth accounts — the OAuth callback can't reach the redirected endpoint, so login / refresh fail. The Base button currently looks identical regardless of state, making it easy to forget that a profile's Base Url is overridden when switching.
How
i18n
en + zh-CN strings added for `profileBaseConfigured`.
Test plan
🤖 Generated with Claude Code