Skip to content

Complete app backend persistence queue#9

Merged
Cmochance merged 1 commit into
mainfrom
codex-complete-app-backends-v1.0.2
May 6, 2026
Merged

Complete app backend persistence queue#9
Cmochance merged 1 commit into
mainfrom
codex-complete-app-backends-v1.0.2

Conversation

@Cmochance
Copy link
Copy Markdown
Owner

Summary

  • finish P16-P30 app backend persistence with app-state and shared media-library storage
  • add server-backed music, video, PDF, paint, calculator/game/radio persistence paths
  • update README, CHANGELOG, technical notes, and v1.0.2 release notes

Validation

  • npm run build
  • git diff --check
  • git diff --cached --check

@Cmochance Cmochance merged commit 646e80c into main May 6, 2026
@Cmochance Cmochance deleted the codex-complete-app-backends-v1.0.2 branch May 6, 2026 16:51
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

if (!loadedRef.current || !payloadPath || !isAudioName(payloadPath)) return;

P1 Badge Trigger payload import after initial media load

The payload-open effect is gated by loadedRef.current, but loadedRef is a ref mutation and does not trigger a re-render. When a window is opened from File Manager, payloadPath is usually already set on first render, so this effect runs once, bails out (loadedRef.current === false), and never runs again after the async library load completes; the requested file is therefore not opened. This breaks the open-with flow for this app (and the same pattern appears in the new Video/PDF handlers).


const deletePhoto = (id: string) => {
setPhotos(prev => prev.filter(p => p.id !== id));
if (lightboxPhoto === id) setLightboxPhoto(null);

P2 Badge Persist camera deletions to shared photo state

Deleting a photo only updates the local photos state, but this component now reloads captures from the shared photo library on mount. As a result, deleted camera photos reappear after reopening the app or refreshing because their metadata was never removed from persisted storage. The delete path should also update the shared photo library/app-state record, not just in-memory UI state.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant