Remove chat components from skirmish lobby#40
Merged
MahBoiDeveloper merged 2 commits intomasterfrom Feb 8, 2026
Merged
Conversation
Member
Author
|
To better demonstrate the possible display issue (note that this control is not disabled in skirmish lobby) |
SadPencil
changed the title
MahBoiDeveloper
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, this component should not exist in Skirmish Lobby. Since XNAUI v3.1.1, there is a chance that tbChatInput shows as a vertical bar in Skirmish Lobby (because it has a default height > 0 now) -- but the border in CnCNet YR/the mod base covers it so I didn't reproduce this display issue in CnCNet YR or the mod base. The screenshot below is from Mental Omega
Better to remove this tbChatInput from Skirmish Lobby anyhow, in case it causes some trouble in the future.