Fix bug with multiple hooks in a blade template#7
Merged
Conversation
… to setting the same use multiple times. Swaps to use fully qualified facade path. Add test to ensure its resolved.
Xulai
approved these changes
Jul 11, 2022
vroomfondle
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the blade template was making use of a
usestatement to import the hook facade - this meant when multiple hooks were set within the blade template, the use statement would get generated in to the result multiple times causingCannot use CoInvestor\LaraHook\Facades\Hook as Hook because the name is already in use in ...errors.This has been resolved by swapping over to using the fully qualified facade name instead.
A test has been added to ensure this functions as expected.
Thanks to #6 for reporting this bug.