✨Feat: 공통 헤더 컴포넌트 작성 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
LeeCh0129
approved these changes
Jun 7, 2025
LeeCh0129
left a comment
LeeCh0129
left a comment
There was a problem hiding this comment.
헤더 컴포넌트를 잘구현해주셨고, 상태 관리와 persist 미들웨어로 상태 유지 구현까지 미리 잘 작성해주셨네요. 고생하셨습니다~👍
Insung-Jo
approved these changes
Jun 7, 2025
Insung-Jo
left a comment
Insung-Jo
left a comment
There was a problem hiding this comment.
리뷰 남겼습니다! 헤더 작성 잘해주셨고 논의 사항이나 궁금한 점은 리뷰로 남겨드렸습니다!
There was a problem hiding this comment.
이 부분은 저도 비슷하게 작성하고 있어서 제가 PR 올리기 전에 같이 살펴보고 결정하는 게 좋을 거 같아요!
| // alias 설정 | ||
| "@/*": ["./src/*"], | ||
| "@components/*": ["./src/app/shared/components/*"], | ||
| "@store/*": ["./src/app/shared/store/*"], |
Contributor
Author
There was a problem hiding this comment.
아무래도 자주 사용할 것 같아서 추가해놨습니당
dkslel1225
approved these changes
Jun 7, 2025
| const { user, logout } = useUserStore() // Zustand 상태 | ||
|
|
||
| return ( | ||
| <header className="flex items-center justify-between border-b border-gray-200 bg-white px-36 py-16 dark:border-gray-700 dark:bg-black"> |
Contributor
There was a problem hiding this comment.
제가 global.css에 작성해둔 커스텀 유틸 클래스
BG-white, Border-section 사용하시면 더 간결하게 다크모드 적용 가능합니다!
혹시 직접 특정 색상을 사용하고 싶으셨던 건가요??
Contributor
Author
There was a problem hiding this comment.
일단 임시로 적어둔 거라 추후 수정할 계획입니당!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항 개요
헤더 공통 컴포넌트 작성
✨ 요약
📝 상세 내용
🎨style
✨Feat
Header.tsx에서 use client 사용 이유:
useRouter()가 서버 컴포넌트에서 호출하면 동작하지 않으며 클라이언트에서만 동작하는 기능이기 때문.
🔍 서버 컴포넌트에서 사용 불가한 이유
🔗 관련 이슈
#7
🖼️ 스크린샷
20250607_185856.mp4
✅ 체크리스트
💡 참고 사항