refactor: migrate CI workflows to self-hosted runners with ephemeral …#133
Merged
Conversation
…environment isolation and workspace cleanup
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gitvishalshetty
requested changes
Apr 28, 2026
|
|
||
| name: CI | ||
|
|
||
| on: |
Contributor
There was a problem hiding this comment.
Empty Trigger Block
- Error: The on: block is empty. This workflow will never trigger.
- Fix: Define the triggers (e.g., push: branches: [main, develop] and pull_request:).
|
|
||
| jobs: | ||
| lint-and-audit: | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
Duplicate runs-on Keys
- Error: The lint-and-audit, security-sast, and reproducible-builds jobs contain duplicate runs-on keys (ubuntu-latest immediately followed by [self-hosted, hetzner, x64]).
- Fix: Remove all instances of runs-on: ubuntu-latest.
| run: uv run deptry src/ | ||
| shell: bash | ||
|
|
||
| - name: Docs Link Validation |
Contributor
There was a problem hiding this comment.
Empty with Block
- Error: In the Docs Link Validation step, the with: key is completely empty.
- Fix: Remove the with: key entirely, or restore the missing args: payload.
| if: always() && needs.lint-and-audit.result == 'success' && needs.security-sast.result == 'success' | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
Contributor
There was a problem hiding this comment.
Conflicting Matrix and Execution Substrate
- Error: The test job defines a cross-platform matrix (ubuntu-latest, windows-latest, macos-latest) but immediately hardcodes the execution to runs-on: [self-hosted, hetzner, x64]. The matrix will execute 3 concurrent jobs on the exact same Linux Hetzner nodes, rendering the OS matrix useless and wasting compute.
- Fix: Delete the matrix: os: array and runs-on: ${{ matrix.os }}. Keep only runs-on: [self-hosted, hetzner, x64].
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
| with: |
Contributor
There was a problem hiding this comment.
Fatal YAML Syntax Error (Empty with)
- Error: The Install uv step has an empty with: block immediately followed by the next array element (- name: Set up Python). This breaks YAML parsing.
- Fix: Restore the missing configuration (e.g., enable-cache: true) or delete the with: key.
| - name: Set up Python | ||
| uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} |
Contributor
There was a problem hiding this comment.
Duplicate Dictionary Keys
- Error: python-version is defined twice in the same block (${{ matrix.python-version }} and "3.14-dev").
- Fix: Remove python-version: ${{ matrix.python-version }}.
| sudo chown -R $(whoami):$(whoami) ${{ github.workspace }} | ||
| shell: bash | ||
|
|
||
| reproducible-builds: |
Contributor
There was a problem hiding this comment.
Severe Merge Corruption (Fatal Error)
- Error: The Set up Python step inside the reproducible-builds job has been destroyed by a bad copy/paste. A bash script fragment (fi and echo) is pasted directly into the with: block. Furthermore, the entire "Build wheel" and "Verify deterministic build" steps are completely missing.
- Fix: Delete lines 235-237. Restore the correct Python version configuration, and rewrite the missing sequential bash steps for building and hashing the wheels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…environment isolation and workspace cleanup