Skip to content

fix(sglang): enable logprob parsing for SGLang client#140

Merged
dk-uppi-aks merged 5 commits into
developfrom
fix-issue-128-sglang-logprobs-4781240915082436270
May 5, 2026
Merged

fix(sglang): enable logprob parsing for SGLang client#140
dk-uppi-aks merged 5 commits into
developfrom
fix-issue-128-sglang-logprobs-4781240915082436270

Conversation

@gowthamrao
Copy link
Copy Markdown
Contributor

Fixes issue #128 by:

  • Enabling return_logprob and top_logprobs_num=1 in SGLang request body.
  • Robustly extracting logarithmic probabilities from input/output token logprobs in meta_info.
  • Converting logarithmic values to linear probabilities via math.exp.
  • Retaining hardcoded probabilities strictly as a fallback.
  • Updating tests to inject logprob mock structures and assert correct propagation.

PR created automatically by Jules for task 4781240915082436270 started by @gowthamrao

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dk-uppi-aks dk-uppi-aks merged commit de8b9fd into develop May 5, 2026
5 checks passed
@dk-uppi-aks dk-uppi-aks deleted the fix-issue-128-sglang-logprobs-4781240915082436270 branch May 5, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants